fix(replace): add missing types for new preventAssignment option
#813
Conversation
|
@danielroe I am pretty sure my error is not related to typings, as I am not executing it in typescript. |
|
@diego-antonelli Would you check - as I noticed your tests are written in TypeScript? (A type error would cause jest specs to fail, whereas the warning shouldn't cause rollup to abort the build - but I might be wrong!) |
I am doing a quick test, please wait 5 min to merge this PR, please |
|
@danielroe indeed was just the typings. Funny thing is: Jest is simply dying without throw any error, but this is not related to your fix. Thanks a lot for the quick fix!! |
* fix type error in `@rollup/plugin-replace` pending rollup/plugins#813 closes #204
|
Thanks for the PR. Looks like a few checks are failing there. Please have a look. |
|
@shellscape The unit tests are all succeeding. Looks like it is a |
|
okay thanks for taking a look. I'll see what I can do about that in a few hours today |
|
Looks like codecov is having some issues today. We'll bypass. Thanks for the fix. |
Rollup Plugin Name:
@rollup/replaceThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
🤦♂️ Failed to add types for change in previous PR (#798). Closes #812.